homberghp commented on PR #8453: URL: https://github.com/apache/netbeans/pull/8453#issuecomment-2833567250
> This is the seventh PR opened that claims to solve this issue! Please make sure PRs are ready for review when opened, or mark them as draft so people know how to treat them. Some of us are tracking all notifications in the repo. And please, in most cases force push your original branch to keep the original PR open so the connection to any discussions and review is not lost. Sorry for the inconvenience, if I messed up. According to lahodaj and mbien my earlier attempts were way too big, to which I agree. Rolling back my rejected changes was undoable, so I simply started again and picked the usable parts of the earlier attempt. > > Is this PR reviewable at this point? Yes, its is reviewable and way smaller. It passes all tests, including some I had to add after I found some additional issues, where previous attempts messed up unrelated tests, in particular Rename. In this version I stick to the bare minimum to in the code, although some more work has been done on the testing front. CasualDiff and its friends put up a fair fight to understand them. It was a steep learning curve for me. Thank you for your patience. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
