neilcsmith-net commented on PR #8462: URL: https://github.com/apache/netbeans/pull/8462#issuecomment-2841283475
> NbClipboard itself is asynchronous, the test is assuming copy/paste are blocking operations, Which they were. I was curious why returning the copy behaviour to that before #7928 was now causing a test failure. But of course, we're not returning the paste behaviour to the old behaviour, which would have called through NbClipboard::getContents and blocked on the pending change. I think we need some thought about whether it's desirable to keep the NbClipboard asynchronous behaviour? It could just be for content listening with synchronous behaviour? Or we could force syncing the clipboard in the basekit paste action - https://github.com/apache/netbeans/blob/master/ide/editor.lib/src/org/netbeans/editor/BaseKit.java#L2399 ?? Given that and where we are at with NB26, we might consider it safer to pull this and reconsider for NB27? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
