adamturcsan commented on code in PR #8478:
URL: https://github.com/apache/netbeans/pull/8478#discussion_r2078353575
##########
php/php.phpunit/src/org/netbeans/modules/php/phpunit/preferences/PhpUnitPreferencesValidator.java:
##########
@@ -60,11 +60,12 @@ public PhpUnitPreferencesValidator
validateCustomSuite(boolean customSuiteEnable
}
public PhpUnitPreferencesValidator validatePhpUnit(boolean phpUnitEnabled,
String phpUnitPath) {
- if (phpUnitEnabled) {
Review Comment:
You are totally right, this has no change in functionality, only that it now
has an early return if it's not enabled (like in
[validatePath](https://github.com/apache/netbeans/blob/0cbb332843ef9c48452ae82c934df06f5523a6ce/php/php.phpunit/src/org/netbeans/modules/php/phpunit/preferences/PhpUnitPreferencesValidator.java#L73)
) instead of a nested positive case.
It is not relevant for this feature, I'm okay with removing this change, It
is just a remnant of me trying to figure out a solution for my problem :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
