neilcsmith-net commented on code in PR #41:
URL: 
https://github.com/apache/netbeans-antora-site/pull/41#discussion_r2081261896


##########
modules/ROOT/pages/download/nb26/index.adoc:
##########
@@ -0,0 +1,139 @@
+////
+     Licensed to the Apache Software Foundation (ASF) under one
+     or more contributor license agreements.  See the NOTICE file
+     distributed with this work for additional information
+     regarding copyright ownership.  The ASF licenses this file
+     to you under the Apache License, Version 2.0 (the
+     "License"); you may not use this file except in compliance
+     with the License.  You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+     Unless required by applicable law or agreed to in writing,
+     software distributed under the License is distributed on an
+     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+     KIND, either express or implied.  See the License for the
+     specific language governing permissions and limitations
+     under the License.
+////
+////
+
+NOTE: 
+See https://www.apache.org/dev/release-download-pages.html 
+for important requirements for download pages for Apache projects.
+
+////
+= Downloading Apache NetBeans 26
+:page-layout: page_noaside
+:page-tags: download
+:jbake-status: published
+:keywords: Apache NetBeans 25 Download
+:description: Apache NetBeans 25 Download
+:toc: left
+:toc-title:
+:icons: font
+
+// check version above and follow the TODOs
+:netbeans-version: 26
+// TODO            ^^
+
+// https://infra.apache.org/release-distribution.html#download-links
+// TODO base URLs - when archiving, delete the next 2 lines and uncomment the 
following 2
+:url-download: https://www.apache.org/dyn/closer.lua/netbeans/
+:url-download-keychecksum: https://downloads.apache.org/netbeans/
+// :url-download: https://archive.apache.org/dist/netbeans/
+// :url-download-keychecksum: https://archive.apache.org/dist/netbeans/
+
+//// 
+url-download depends of release status archived or not
+https://archive.apache.org/dist/netbeans/  (//archived)
+https://www.apache.org/dyn/closer.lua/netbeans/ (//current)
+
+url-download-keychecksum depends of release status archived or not
+https://archive.apache.org/dist/netbeans/  (//archived)
+https://downloads.apache.org/netbeans/ (//current)
+////
+
+Apache NetBeans {netbeans-version} was released on May xxx, 2025.
+// TODO update date                                ^^^^
+
+////
+NOTE: It's mandatory to link to the source. It's optional to link to the 
binaries.
+NOTE: It's mandatory to link against https://www.apache.org for the sums & 
keys. https is recommended.
+NOTE: It's NOT recommended to link to github.
+////
+
+*Binaries (Platform Independent):*

Review Comment:
   "Binary" singular?



##########
modules/ROOT/pages/download/nb26/index.adoc:
##########
@@ -0,0 +1,139 @@
+////
+     Licensed to the Apache Software Foundation (ASF) under one
+     or more contributor license agreements.  See the NOTICE file
+     distributed with this work for additional information
+     regarding copyright ownership.  The ASF licenses this file
+     to you under the Apache License, Version 2.0 (the
+     "License"); you may not use this file except in compliance
+     with the License.  You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+     Unless required by applicable law or agreed to in writing,
+     software distributed under the License is distributed on an
+     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+     KIND, either express or implied.  See the License for the
+     specific language governing permissions and limitations
+     under the License.
+////
+////
+
+NOTE: 
+See https://www.apache.org/dev/release-download-pages.html 
+for important requirements for download pages for Apache projects.
+
+////
+= Downloading Apache NetBeans 26
+:page-layout: page_noaside
+:page-tags: download
+:jbake-status: published
+:keywords: Apache NetBeans 25 Download
+:description: Apache NetBeans 25 Download
+:toc: left
+:toc-title:
+:icons: font
+
+// check version above and follow the TODOs
+:netbeans-version: 26
+// TODO            ^^
+
+// https://infra.apache.org/release-distribution.html#download-links
+// TODO base URLs - when archiving, delete the next 2 lines and uncomment the 
following 2
+:url-download: https://www.apache.org/dyn/closer.lua/netbeans/
+:url-download-keychecksum: https://downloads.apache.org/netbeans/
+// :url-download: https://archive.apache.org/dist/netbeans/
+// :url-download-keychecksum: https://archive.apache.org/dist/netbeans/
+
+//// 
+url-download depends of release status archived or not
+https://archive.apache.org/dist/netbeans/  (//archived)
+https://www.apache.org/dyn/closer.lua/netbeans/ (//current)
+
+url-download-keychecksum depends of release status archived or not
+https://archive.apache.org/dist/netbeans/  (//archived)
+https://downloads.apache.org/netbeans/ (//current)
+////
+
+Apache NetBeans {netbeans-version} was released on May xxx, 2025.
+// TODO update date                                ^^^^
+
+////
+NOTE: It's mandatory to link to the source. It's optional to link to the 
binaries.
+NOTE: It's mandatory to link against https://www.apache.org for the sums & 
keys. https is recommended.
+NOTE: It's NOT recommended to link to github.
+////
+
+*Binaries (Platform Independent):*
+
+* 
link:{url-download}netbeans/{netbeans-version}/netbeans-{netbeans-version}-bin.zip?action=download[netbeans-{netbeans-version}-bin.zip]

Review Comment:
   Could be nice to have the links for zips and to packages as buttons?  Can we 
add classes (`.button`, `.success`, etc.) to links using this syntax?



##########
modules/ROOT/pages/download/nb26/index.adoc:
##########
@@ -0,0 +1,139 @@
+////
+     Licensed to the Apache Software Foundation (ASF) under one
+     or more contributor license agreements.  See the NOTICE file
+     distributed with this work for additional information
+     regarding copyright ownership.  The ASF licenses this file
+     to you under the Apache License, Version 2.0 (the
+     "License"); you may not use this file except in compliance
+     with the License.  You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+     Unless required by applicable law or agreed to in writing,
+     software distributed under the License is distributed on an
+     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+     KIND, either express or implied.  See the License for the
+     specific language governing permissions and limitations
+     under the License.
+////
+////
+
+NOTE: 
+See https://www.apache.org/dev/release-download-pages.html 
+for important requirements for download pages for Apache projects.
+
+////
+= Downloading Apache NetBeans 26
+:page-layout: page_noaside
+:page-tags: download
+:jbake-status: published
+:keywords: Apache NetBeans 25 Download
+:description: Apache NetBeans 25 Download
+:toc: left
+:toc-title:
+:icons: font
+
+// check version above and follow the TODOs
+:netbeans-version: 26
+// TODO            ^^
+
+// https://infra.apache.org/release-distribution.html#download-links
+// TODO base URLs - when archiving, delete the next 2 lines and uncomment the 
following 2
+:url-download: https://www.apache.org/dyn/closer.lua/netbeans/
+:url-download-keychecksum: https://downloads.apache.org/netbeans/
+// :url-download: https://archive.apache.org/dist/netbeans/
+// :url-download-keychecksum: https://archive.apache.org/dist/netbeans/
+
+//// 
+url-download depends of release status archived or not
+https://archive.apache.org/dist/netbeans/  (//archived)
+https://www.apache.org/dyn/closer.lua/netbeans/ (//current)
+
+url-download-keychecksum depends of release status archived or not
+https://archive.apache.org/dist/netbeans/  (//archived)
+https://downloads.apache.org/netbeans/ (//current)
+////
+
+Apache NetBeans {netbeans-version} was released on May xxx, 2025.
+// TODO update date                                ^^^^
+
+////
+NOTE: It's mandatory to link to the source. It's optional to link to the 
binaries.
+NOTE: It's mandatory to link against https://www.apache.org for the sums & 
keys. https is recommended.
+NOTE: It's NOT recommended to link to github.
+////
+
+*Binaries (Platform Independent):*
+
+* 
link:{url-download}netbeans/{netbeans-version}/netbeans-{netbeans-version}-bin.zip?action=download[netbeans-{netbeans-version}-bin.zip]
+ 
(link:{url-download-keychecksum}netbeans/{netbeans-version}/netbeans-{netbeans-version}-bin.zip.sha512[SHA-512],
+ 
link:{url-download-keychecksum}netbeans/{netbeans-version}/netbeans-{netbeans-version}-bin.zip.asc[PGP
 ASC])
+
+*Source:*
+
+* 
link:{url-download}netbeans/{netbeans-version}/netbeans-{netbeans-version}-source.zip?action=download[netbeans-{netbeans-version}-source.zip]
 
+(link:{url-download-keychecksum}netbeans/{netbeans-version}/netbeans-{netbeans-version}-source.zip.sha512[SHA-512],
 
+link:{url-download-keychecksum}netbeans/{netbeans-version}/netbeans-{netbeans-version}-source.zip.asc[PGP
 ASC])
+
+Officially, it is important that you 
link:https://www.apache.org/dyn/closer.lua#verify[verify the integrity]
+of the downloaded files using the PGP signatures (.asc file) or a hash 
(.sha512 files).
+The PGP keys used to sign this release are available 
link:https://downloads.apache.org/netbeans/KEYS[here].

Review Comment:
   This sentence causes so much end user confusion!
   
   Why not something a bit friendlier - "You can verify the integrity of the 
downloaded files using the PGP signatures (.asc files) or hash (.sha512 files)" 
?



##########
modules/ROOT/pages/download/nb26/index.adoc:
##########
@@ -0,0 +1,139 @@
+////
+     Licensed to the Apache Software Foundation (ASF) under one
+     or more contributor license agreements.  See the NOTICE file
+     distributed with this work for additional information
+     regarding copyright ownership.  The ASF licenses this file
+     to you under the Apache License, Version 2.0 (the
+     "License"); you may not use this file except in compliance
+     with the License.  You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+     Unless required by applicable law or agreed to in writing,
+     software distributed under the License is distributed on an
+     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+     KIND, either express or implied.  See the License for the
+     specific language governing permissions and limitations
+     under the License.
+////
+////
+
+NOTE: 
+See https://www.apache.org/dev/release-download-pages.html 
+for important requirements for download pages for Apache projects.
+
+////
+= Downloading Apache NetBeans 26
+:page-layout: page_noaside
+:page-tags: download
+:jbake-status: published
+:keywords: Apache NetBeans 25 Download
+:description: Apache NetBeans 25 Download
+:toc: left
+:toc-title:
+:icons: font
+
+// check version above and follow the TODOs
+:netbeans-version: 26
+// TODO            ^^
+
+// https://infra.apache.org/release-distribution.html#download-links
+// TODO base URLs - when archiving, delete the next 2 lines and uncomment the 
following 2
+:url-download: https://www.apache.org/dyn/closer.lua/netbeans/
+:url-download-keychecksum: https://downloads.apache.org/netbeans/
+// :url-download: https://archive.apache.org/dist/netbeans/
+// :url-download-keychecksum: https://archive.apache.org/dist/netbeans/
+
+//// 
+url-download depends of release status archived or not
+https://archive.apache.org/dist/netbeans/  (//archived)
+https://www.apache.org/dyn/closer.lua/netbeans/ (//current)
+
+url-download-keychecksum depends of release status archived or not
+https://archive.apache.org/dist/netbeans/  (//archived)
+https://downloads.apache.org/netbeans/ (//current)
+////
+
+Apache NetBeans {netbeans-version} was released on May xxx, 2025.
+// TODO update date                                ^^^^
+
+////
+NOTE: It's mandatory to link to the source. It's optional to link to the 
binaries.
+NOTE: It's mandatory to link against https://www.apache.org for the sums & 
keys. https is recommended.
+NOTE: It's NOT recommended to link to github.
+////
+
+*Binaries (Platform Independent):*
+
+* 
link:{url-download}netbeans/{netbeans-version}/netbeans-{netbeans-version}-bin.zip?action=download[netbeans-{netbeans-version}-bin.zip]
+ 
(link:{url-download-keychecksum}netbeans/{netbeans-version}/netbeans-{netbeans-version}-bin.zip.sha512[SHA-512],
+ 
link:{url-download-keychecksum}netbeans/{netbeans-version}/netbeans-{netbeans-version}-bin.zip.asc[PGP
 ASC])
+
+*Source:*
+
+* 
link:{url-download}netbeans/{netbeans-version}/netbeans-{netbeans-version}-source.zip?action=download[netbeans-{netbeans-version}-source.zip]
 
+(link:{url-download-keychecksum}netbeans/{netbeans-version}/netbeans-{netbeans-version}-source.zip.sha512[SHA-512],
 
+link:{url-download-keychecksum}netbeans/{netbeans-version}/netbeans-{netbeans-version}-source.zip.asc[PGP
 ASC])
+
+Officially, it is important that you 
link:https://www.apache.org/dyn/closer.lua#verify[verify the integrity]
+of the downloaded files using the PGP signatures (.asc file) or a hash 
(.sha512 files).
+The PGP keys used to sign this release are available 
link:https://downloads.apache.org/netbeans/KEYS[here].
+
+*Release Notes:*
+
+* 
link:https://github.com/apache/netbeans/releases/tag/{netbeans-version}[Github 
Link]
+
+== Community Installers
+
+- link:https://installers.friendsofapachenetbeans.org/[Friends of Apache 
NetBeans] - Windows, macOS and
+Linux (.deb / .rpm / .AppImage) built with 
link:https://github.com/apache/netbeans-nbpackage/[NBPackage]. Most
+include a local JDK runtime for the IDE to run on, for a self-contained 
out-of-the-box experience.

Review Comment:
   Remove `.AppImage` - not planned for NB26 at the moment.
   
   Change to "All include a local JDK runtime ..."



##########
modules/ROOT/pages/download/nb26/index.adoc:
##########
@@ -0,0 +1,139 @@
+////
+     Licensed to the Apache Software Foundation (ASF) under one
+     or more contributor license agreements.  See the NOTICE file
+     distributed with this work for additional information
+     regarding copyright ownership.  The ASF licenses this file
+     to you under the Apache License, Version 2.0 (the
+     "License"); you may not use this file except in compliance
+     with the License.  You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+     Unless required by applicable law or agreed to in writing,
+     software distributed under the License is distributed on an
+     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+     KIND, either express or implied.  See the License for the
+     specific language governing permissions and limitations
+     under the License.
+////
+////
+
+NOTE: 
+See https://www.apache.org/dev/release-download-pages.html 
+for important requirements for download pages for Apache projects.
+
+////
+= Downloading Apache NetBeans 26
+:page-layout: page_noaside
+:page-tags: download
+:jbake-status: published
+:keywords: Apache NetBeans 25 Download
+:description: Apache NetBeans 25 Download
+:toc: left
+:toc-title:
+:icons: font
+
+// check version above and follow the TODOs
+:netbeans-version: 26
+// TODO            ^^
+
+// https://infra.apache.org/release-distribution.html#download-links
+// TODO base URLs - when archiving, delete the next 2 lines and uncomment the 
following 2
+:url-download: https://www.apache.org/dyn/closer.lua/netbeans/
+:url-download-keychecksum: https://downloads.apache.org/netbeans/
+// :url-download: https://archive.apache.org/dist/netbeans/
+// :url-download-keychecksum: https://archive.apache.org/dist/netbeans/
+
+//// 
+url-download depends of release status archived or not
+https://archive.apache.org/dist/netbeans/  (//archived)
+https://www.apache.org/dyn/closer.lua/netbeans/ (//current)
+
+url-download-keychecksum depends of release status archived or not
+https://archive.apache.org/dist/netbeans/  (//archived)
+https://downloads.apache.org/netbeans/ (//current)
+////
+
+Apache NetBeans {netbeans-version} was released on May xxx, 2025.
+// TODO update date                                ^^^^
+
+////
+NOTE: It's mandatory to link to the source. It's optional to link to the 
binaries.
+NOTE: It's mandatory to link against https://www.apache.org for the sums & 
keys. https is recommended.
+NOTE: It's NOT recommended to link to github.
+////
+
+*Binaries (Platform Independent):*
+
+* 
link:{url-download}netbeans/{netbeans-version}/netbeans-{netbeans-version}-bin.zip?action=download[netbeans-{netbeans-version}-bin.zip]
+ 
(link:{url-download-keychecksum}netbeans/{netbeans-version}/netbeans-{netbeans-version}-bin.zip.sha512[SHA-512],
+ 
link:{url-download-keychecksum}netbeans/{netbeans-version}/netbeans-{netbeans-version}-bin.zip.asc[PGP
 ASC])
+
+*Source:*
+
+* 
link:{url-download}netbeans/{netbeans-version}/netbeans-{netbeans-version}-source.zip?action=download[netbeans-{netbeans-version}-source.zip]
 
+(link:{url-download-keychecksum}netbeans/{netbeans-version}/netbeans-{netbeans-version}-source.zip.sha512[SHA-512],
 
+link:{url-download-keychecksum}netbeans/{netbeans-version}/netbeans-{netbeans-version}-source.zip.asc[PGP
 ASC])
+
+Officially, it is important that you 
link:https://www.apache.org/dyn/closer.lua#verify[verify the integrity]
+of the downloaded files using the PGP signatures (.asc file) or a hash 
(.sha512 files).
+The PGP keys used to sign this release are available 
link:https://downloads.apache.org/netbeans/KEYS[here].
+
+*Release Notes:*
+
+* 
link:https://github.com/apache/netbeans/releases/tag/{netbeans-version}[Github 
Link]
+
+== Community Installers

Review Comment:
   "Installers and Packages"?



##########
modules/ROOT/pages/download/nb26/index.adoc:
##########
@@ -0,0 +1,139 @@
+////
+     Licensed to the Apache Software Foundation (ASF) under one
+     or more contributor license agreements.  See the NOTICE file
+     distributed with this work for additional information
+     regarding copyright ownership.  The ASF licenses this file
+     to you under the Apache License, Version 2.0 (the
+     "License"); you may not use this file except in compliance
+     with the License.  You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+     Unless required by applicable law or agreed to in writing,
+     software distributed under the License is distributed on an
+     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+     KIND, either express or implied.  See the License for the
+     specific language governing permissions and limitations
+     under the License.
+////
+////
+
+NOTE: 
+See https://www.apache.org/dev/release-download-pages.html 
+for important requirements for download pages for Apache projects.
+
+////
+= Downloading Apache NetBeans 26
+:page-layout: page_noaside
+:page-tags: download
+:jbake-status: published
+:keywords: Apache NetBeans 25 Download
+:description: Apache NetBeans 25 Download
+:toc: left
+:toc-title:
+:icons: font
+
+// check version above and follow the TODOs
+:netbeans-version: 26
+// TODO            ^^
+
+// https://infra.apache.org/release-distribution.html#download-links
+// TODO base URLs - when archiving, delete the next 2 lines and uncomment the 
following 2
+:url-download: https://www.apache.org/dyn/closer.lua/netbeans/
+:url-download-keychecksum: https://downloads.apache.org/netbeans/
+// :url-download: https://archive.apache.org/dist/netbeans/
+// :url-download-keychecksum: https://archive.apache.org/dist/netbeans/
+
+//// 
+url-download depends of release status archived or not
+https://archive.apache.org/dist/netbeans/  (//archived)
+https://www.apache.org/dyn/closer.lua/netbeans/ (//current)
+
+url-download-keychecksum depends of release status archived or not
+https://archive.apache.org/dist/netbeans/  (//archived)
+https://downloads.apache.org/netbeans/ (//current)
+////
+
+Apache NetBeans {netbeans-version} was released on May xxx, 2025.
+// TODO update date                                ^^^^
+
+////
+NOTE: It's mandatory to link to the source. It's optional to link to the 
binaries.
+NOTE: It's mandatory to link against https://www.apache.org for the sums & 
keys. https is recommended.
+NOTE: It's NOT recommended to link to github.
+////
+
+*Binaries (Platform Independent):*
+
+* 
link:{url-download}netbeans/{netbeans-version}/netbeans-{netbeans-version}-bin.zip?action=download[netbeans-{netbeans-version}-bin.zip]
+ 
(link:{url-download-keychecksum}netbeans/{netbeans-version}/netbeans-{netbeans-version}-bin.zip.sha512[SHA-512],
+ 
link:{url-download-keychecksum}netbeans/{netbeans-version}/netbeans-{netbeans-version}-bin.zip.asc[PGP
 ASC])
+
+*Source:*
+
+* 
link:{url-download}netbeans/{netbeans-version}/netbeans-{netbeans-version}-source.zip?action=download[netbeans-{netbeans-version}-source.zip]
 
+(link:{url-download-keychecksum}netbeans/{netbeans-version}/netbeans-{netbeans-version}-source.zip.sha512[SHA-512],
 
+link:{url-download-keychecksum}netbeans/{netbeans-version}/netbeans-{netbeans-version}-source.zip.asc[PGP
 ASC])
+
+Officially, it is important that you 
link:https://www.apache.org/dyn/closer.lua#verify[verify the integrity]
+of the downloaded files using the PGP signatures (.asc file) or a hash 
(.sha512 files).
+The PGP keys used to sign this release are available 
link:https://downloads.apache.org/netbeans/KEYS[here].
+
+*Release Notes:*
+
+* 
link:https://github.com/apache/netbeans/releases/tag/{netbeans-version}[Github 
Link]
+
+== Community Installers
+
+- link:https://installers.friendsofapachenetbeans.org/[Friends of Apache 
NetBeans] - Windows, macOS and
+Linux (.deb / .rpm / .AppImage) built with 
link:https://github.com/apache/netbeans-nbpackage/[NBPackage]. Most
+include a local JDK runtime for the IDE to run on, for a self-contained 
out-of-the-box experience.
+- link:https://snapcraft.io/netbeans[Linux snap package]
+
+IMPORTANT: Individual NetBeans committers may provide additional binary 
packages as a convenience.
+While built using the Apache NetBeans release, they are not releases of the 
Apache Software
+Foundation. They may include other contents (eg. JDK) under additional license 
terms.

Review Comment:
   IMPORTANT: These installers and packages are provided by various NetBeans 
committers as a convenience. While built using the Apache NetBeans release, 
they are not releases of the Apache Software Foundation. They may include other 
contents (eg. JDK) under additional license terms.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to