rkeen-siemens commented on issue #8513: URL: https://github.com/apache/netbeans/issues/8513#issuecomment-2901601793
> Somewhat open question whether this is a desirable option in the IDE itself? I'm not sure of the history in the IDE regarding why the icons aren't shown, but unless there's a good reason I would advocate for the icons to be always displayed. > Realistically, enhancements of the platform that add complexity, but are not desired in the IDE itself, probably require direct or indirect investment in their development and maintenance. We had originally thought to override `FlatViewTabDisplayerUI` and draw the icon in our own UI delegate, but ran into a couple issues: 1. `FlatViewTabDisplayerUI` is public, but is not in a publicly available package (at least not to our module) 2. `paintTabContent` paints a busy icon and the text, so overriding it would not (easily) allow for painting the icon between the busy icon and the text where it would logically belong. The simple approach might be to introduce a `paintTabIcon` protected method in `AbstractViewTabDisplayerUI` that could be called from `paintTabContent` or pull out the busy icon painting to a separate method. It looks like there are quite a few subclasses of `AbstractViewTabDisplayerUI`, so either approach would require some refactoring of all those as well to handle it completely. A more involved approach would be to refactor the view tabs to be rendered similar to the editor tabs using a rendering component for each tab rather and providing the `TabData` instance rather than a tab index. That might allow for more reuse of the generic renders across the various different tab views as well. We have our own fork of the platform and will probably just add icon rendering directly to `FlatViewTabDisplayerUI` in the short term as we don't have the resources for a larger refactoring and only use the FlatLaf UI anyway. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
