neilcsmith-net commented on PR #100: URL: https://github.com/apache/netbeans-nbpackage/pull/100#issuecomment-3004269182
Thanks both! > LGTM, but kind of easier to put live to have the workflow under test :D Well, it did run in the context of the PR - https://github.com/apache/netbeans-nbpackage/actions/runs/15855076769 > Was wondering why this isn't a unit test but it is probably too dependent on the environment to be one. Yes, the unit tests currently cover aspects of cross-platform behaviour, but the packagers themselves are environment dependent. If I can move the architecture testing out of the image construction, which relates to #93, then we should be able to cross-platform unit test the image creation for all packagers. But actually running the packaging itself requires OS-specific tooling. That might be considered within the build in future, but we'd still want to ensure we cover full end-to-end execution, running via the launcher in this way, before verifying the output. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
