cstamas commented on code in PR #243:
URL:
https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/243#discussion_r2166662283
##########
nbm-maven-plugin/pom.xml:
##########
@@ -123,12 +123,6 @@ under the License.
</dependency>
<!-- BAD BOYS: we want to get rid of these -->
- <dependency>
- <groupId>org.apache.maven</groupId>
- <artifactId>maven-compat</artifactId>
- <version>${maven.version}</version>
- <scope>provided</scope>
- </dependency>
Review Comment:
uh oh, this PR _adds it_? Big NO-NO
##########
nbm-maven-plugin/pom.xml:
##########
@@ -123,12 +123,6 @@ under the License.
</dependency>
<!-- BAD BOYS: we want to get rid of these -->
- <dependency>
- <groupId>org.apache.maven</groupId>
- <artifactId>maven-compat</artifactId>
- <version>${maven.version}</version>
- <scope>provided</scope>
- </dependency>
Review Comment:
uh oh, this PR _adds MAT_? Big NO-NO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
