mbien commented on code in PR #246:
URL:
https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/246#discussion_r2193292410
##########
nbm-maven-plugin/src/main/java/org/apache/netbeans/nbm/AbstractNbmMojo.java:
##########
@@ -203,21 +203,12 @@ static List<ModuleWrapper>
getModuleDependencyArtifacts(DependencyNode treeRoot,
depExaminator.checkFile();
examinerCache.put(artifact, depExaminator);
}
- Dependency dep = resolveNetBeansDependency(artifact, deps,
depExaminator, log);
+ Dependency dep = resolveNetBeansDependency(this.artifacts,
artifact, deps, depExaminator, log);
if (dep != null) {
ModuleWrapper wr = new ModuleWrapper();
wr.dependency = dep;
wr.artifact = artifact;
wr.transitive = false;
- //only direct deps matter to us..
- if (depExaminator.isNetBeansModule() &&
artifact.getDependencyTrail().size() > 2) {
- log.debug(
- artifact.getId()
- + " omitted as NetBeans module dependency, not a
direct one. "
- + "Declare it in the pom for inclusion.");
- wr.transitive = true;
-
- }
include.add(wr);
Review Comment:
wondering if it is ok to remove this.
`wr.transitive` not used anywhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
