lahodaj commented on PR #8700: URL: https://github.com/apache/netbeans/pull/8700#issuecomment-3151995172
My opinion: it is better to make an effort to find reproducers, and look what exactly is happening, than just adding `null` checks without trying. If we can't, with a reasonable effort, find a reproducer, then it might be OK to just add a `null` check, but we should be aware it is not unlikely to surface somewhere else. There are (at least) two reasons: - the `null` value often means that some part of the attribution didn't happen even though it should have. The `null` check will prevent the NPE, but will not make all the other features that rely on properly attributed AST to work. Sometimes, there's not much that can be improved, other times, things can be improved. - if there's no test, there's a possibility that the problem will resurface. Not that likely for a `null` check, but may happen. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
