mbien opened a new pull request, #8739:
URL: https://github.com/apache/netbeans/pull/8739
- remove `--add-opens` flags if possible.
- some usages (e.g. reflective constructor invocation in `FormLAF`) allow
to change `opens` into `exports` when only public API is used
- add comments to some of the encapsulation breaking usage
spec: https://openjdk.org/jeps/261
NB builds and runs without `--add-exports` of the `jdk.comiler` API but I
kept those flags since this area has too many edge cases to think though.
more testing is needed, running NB 27 with the following flags right now:
<details>
```
jms_options="-J--enable-native-access=ALL-UNNAMED \
-J--add-opens=java.base/java.net=ALL-UNNAMED \
-J--add-opens=java.base/java.util=ALL-UNNAMED \
-J--add-opens=java.base/java.nio=ALL-UNNAMED \
-J--add-opens=java.base/java.security=ALL-UNNAMED \
-J--add-opens=java.prefs/java.util.prefs=ALL-UNNAMED \
-J--add-opens=java.desktop/javax.swing.text=ALL-UNNAMED \
-J--add-opens=java.desktop/java.awt=ALL-UNNAMED \
-J--add-opens=java.desktop/javax.swing=ALL-UNNAMED \
-J--add-exports=java.desktop/com.sun.java.swing.plaf.gtk=ALL-UNNAMED \
-J--add-exports=java.desktop/com.sun.java.swing.plaf.windows=ALL-UNNAMED \
-J--add-exports=java.desktop/com.sun.java.swing.plaf.motif=ALL-UNNAMED \
-J--add-exports=java.desktop/com.apple.eio=ALL-UNNAMED \
-J--add-exports=java.desktop/sun.awt=ALL-UNNAMED \
-J--add-exports=java.desktop/java.awt.peer=ALL-UNNAMED \
-J--add-exports=java.desktop/com.sun.beans.editors=ALL-UNNAMED \
-J--add-exports=java.desktop/sun.swing=ALL-UNNAMED \
-J--add-exports=java.desktop/sun.awt.im=ALL-UNNAMED \
-J--add-opens=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED \
-J--add-opens=jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED \
-J--add-opens=jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED \
-J--add-opens=jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED \
-J--add-opens=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED \
-J--add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED \
-J--add-exports=jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED \
-J--add-exports=jdk.compiler/com.sun.tools.javac.comp=ALL-UNNAMED \
-J--add-exports=jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED \
-J--add-exports=jdk.compiler/com.sun.tools.javac.jvm=ALL-UNNAMED \
-J--add-exports=jdk.compiler/com.sun.tools.javac.main=ALL-UNNAMED \
-J--add-exports=jdk.compiler/com.sun.tools.javac.model=ALL-UNNAMED \
-J--add-exports=jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED \
-J--add-exports=jdk.compiler/com.sun.tools.javac.processing=ALL-UNNAMED \
-J--add-exports=jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED \
-J--add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED \
-J--add-modules=jdk.jshell \
-J--add-opens=jdk.jshell/jdk.jshell=ALL-UNNAMED \
-J--add-exports=jdk.jshell/jdk.internal.jshell.debug=ALL-UNNAMED \
-J--add-exports=jdk.jdeps/com.sun.tools.classfile=ALL-UNNAMED \
-J--add-exports=jdk.jdeps/com.sun.tools.javap=ALL-UNNAMED \
-J--add-exports=jdk.internal.jvmstat/sun.jvmstat.monitor=ALL-UNNAMED \
-J--add-exports=jdk.internal.opt/jdk.internal.opt=ALL-UNNAMED \
-J--add-exports=java.management/sun.management=ALL-UNNAMED"
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
