neilcsmith-net commented on code in PR #8756: URL: https://github.com/apache/netbeans/pull/8756#discussion_r2311892066
########## nb/ide.launcher/unix/netbeans: ########## @@ -38,6 +38,9 @@ cd "$progdir"/.. basedir=`pwd` cd "$old" +# make sure own launcher is on PATH +PATH=$PATH:$progdir Review Comment: Setting an environment variable for the basedir and/or the executable file path isn't unusual. If using it directly feels unusual, then a separate script could be used to do this. The problem is anything that already puts `netbeans` on the `PATH`. If you are running an alternative (zip) version with an appended `PATH` then you'll get the default install. That may still do the right thing in most cases, once they have a version of NetBeans with the launcher that understands `NETBEANS_USERDIR` included. I've no idea if other Linux packages play around with `userdir`, although they also not put `netbeans` on the `PATH`, but the `DEB` and `RPM` don't do anything. If the `netbeans` location is prepended, then using the installed RPM or DEB packages this would cause calls to `netbeans` to go directly to `/usr/lib/apache-netbeans/bin/netbeans` rather than via `/usr/bin/netbeans` which would in some cases fail due to missing extra configuration. In all, I have reservations about modifying the `PATH`, but appending would be less likely to break things while not working in all scenarios. Environment variables feel a little more reliable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
