mbien commented on PR #113: URL: https://github.com/apache/netbeans-nbpackage/pull/113#issuecomment-3246154578
> > The error msg of the validator should probably mention the sum if it doesn't match the requested sum. > > Not sure what you mean there? But we need to keep SHA in here. CI should fail on wrong hash with a suitable message. I mean that the mvnw launcher could add the two SHA it compared to the error msg instead of simply saying that they don't match. So the dev could paste it into the properties file after upgrade. CI would detect if anything is wrong there anyway. also: TIL that mvnw supports mvnd already -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
