eirikbakke commented on PR #8799: URL: https://github.com/apache/netbeans/pull/8799#issuecomment-3272735874
(I haven't formed strong opinions on this, so please bear with me...) > once Integer is a value based object, OK option will have the same == identity as the YES option, this PR is one way of addressing this issue before applications break. 1) Is this the only thing that would break? 2) Is there ever a case where a dialog should have both a Yes button and an OK button? Typically you have yes/no/cancel or OK/cancel, but never yes/ok. The latter would be a bit of a usability bug IMO. If the answer is (1) yes and (2) no, then I'd be inclined to agree with Neil's [earlier position](https://github.com/apache/netbeans/pull/8407#issuecomment-3261663067): > I'm still of the opinion that YES_OPTION == OK_OPTION is the least worst fix, and aligns with JOptionPane. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
