donphelix commented on code in PR #8858:
URL: https://github.com/apache/netbeans/pull/8858#discussion_r2386823531


##########
java/java.editor/src/org/netbeans/modules/editor/java/JavaCompletionCollector.java:
##########
@@ -162,6 +166,38 @@ public static Supplier<String> getDocumentation(Document 
doc, int offset, Elemen
                     @Override
                     public Future<String> create(CompilationInfo 
compilationInfo, Element element, Callable<Boolean> cancel) {
                         ElementJavadoc doc = 
ElementJavadoc.create(compilationInfo, element, cancel);
+                        if (doc.getGotoSourceAction() == null && doc.getURL() 
== null) {

Review Comment:
   I’m not trying to nitpick, but the nested if blocks and callbacks make the 
code difficult to follow. It might be helpful to refactor some of the logic 
into smaller helper methods to improve readability.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to