matthiasblaesing commented on code in PR #8189:
URL: https://github.com/apache/netbeans/pull/8189#discussion_r2426834519
##########
ide/db/src/org/netbeans/modules/db/util/DriverListUtil.java:
##########
@@ -404,6 +434,8 @@ public static List<JdbcUrl> getJdbcUrls(JDBCDriver driver) {
for (JdbcUrl url : templateUrls) {
if (url.getClassName().equals(driver.getClassName())) {
JdbcUrl newurl = new JdbcUrl(url, driver);
+
newurl.setUsernamePasswordDisplayed(url.isUsernamePasswordDisplayed());
+
newurl.setDatabaseFileValidator(url.getDatabaseFileValidator());
Review Comment:
There is `org.netbeans.modules.db.util.JdbcUrl.JdbcUrl(JdbcUrl,
JDBCDriver)`. The source jdbc url is passed in and its parameters are already
copied:
https://github.com/apache/netbeans/blob/083a13a24d4b4a4023b84a2faefb3f4a630808fa/ide/db/src/org/netbeans/modules/db/util/JdbcUrl.java#L102-L111
Moving the setter calls from here to JdbcUrl after line 109 seemed logical
to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
