neilcsmith-net commented on code in PR #115:
URL:
https://github.com/apache/netbeans-nbpackage/pull/115#discussion_r2387911974
##########
src/main/java/org/apache/netbeans/nbpackage/StringUtils.java:
##########
@@ -30,11 +30,31 @@
public class StringUtils {
private static final Pattern TOKEN_PATTERN =
Pattern.compile("\\$\\{(.+?)\\}");
+ private static final Pattern SCRIPT_VAR_PATTERN =
Pattern.compile("\\$\\{\\{(.+?)\\}\\}");
private StringUtils() {
// static utilities
}
+ /**
+ * Unescapes the bash variables in the script template
+ *
+ * @param template script template
+ * @return script with unescaped variables
+ */
+ public static String unescapeScriptVars(String script)
Review Comment:
Sure, I understand what you're trying to do, but that should happen anyway
without this extra code as long as the token is not present during packaging -
eg. see the test at
https://github.com/apache/netbeans-nbpackage/blob/51e9d3db6a3438f85f141817d4cd9a97de9b3cc4/src/test/java/org/apache/netbeans/nbpackage/ExecutionContextTest.java#L77-L79
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
