lahodaj commented on code in PR #8937:
URL: https://github.com/apache/netbeans/pull/8937#discussion_r2484835000
##########
java/java.source.base/src/org/netbeans/api/java/source/TreeUtilities.java:
##########
@@ -108,11 +108,42 @@ public final class TreeUtilities {
private static final Logger LOG =
Logger.getLogger(TreeUtilities.class.getName());
- /**{@link Kind}s that are represented by {@link ClassTree}.
+ /**
+ * {@link Kind}s that are represented by {@link ClassTree}.
*
* @since 0.67
*/
- public static final Set<Kind> CLASS_TREE_KINDS =
EnumSet.of(Kind.ANNOTATION_TYPE, Kind.CLASS, Kind.ENUM, Kind.INTERFACE,
Kind.RECORD);
+ public static final Set<Kind> CLASS_TREE_KINDS =
Collections.unmodifiableSet(EnumSet.of(
+ Kind.ANNOTATION_TYPE,
+ Kind.CLASS,
+ Kind.ENUM,
+ Kind.INTERFACE,
+ Kind.RECORD
+ ));
+
+ private static final Set<JavaTokenId> SPAN_COMMENT_TOKENS = EnumSet.of(
+ JavaTokenId.DOT,
+ JavaTokenId.WHITESPACE,
+ JavaTokenId.BLOCK_COMMENT,
+ JavaTokenId.LINE_COMMENT,
+ JavaTokenId.JAVADOC_COMMENT
+ );
+
+ private static final Set<JavaTokenId> SPAN_ClASS_TOKENS = EnumSet.of(
Review Comment:
Nit:
```suggestion
private static final Set<JavaTokenId> SPAN_CLASS_TOKENS = EnumSet.of(
```
##########
java/java.source.base/src/org/netbeans/api/java/source/TreeUtilities.java:
##########
@@ -1142,7 +1178,7 @@ public int[] findBodySpan(ClassTree clazz) {
* @since 0.25
*/
public int[] findNameSpan(ClassTree clazz) {
- return findNameSpan(clazz.getSimpleName().toString(), clazz,
JavaTokenId.CLASS, JavaTokenId.INTERFACE, JavaTokenId.ENUM, JavaTokenId.AT,
JavaTokenId.WHITESPACE, JavaTokenId.BLOCK_COMMENT, JavaTokenId.LINE_COMMENT,
JavaTokenId.JAVADOC_COMMENT);
+ return findNameSpan(clazz.getSimpleName().toString(), clazz,
SPAN_ClASS_TOKENS, SPAN_CLASS_IDENTIFIERS);
Review Comment:
```suggestion
return findNameSpan(clazz.getSimpleName().toString(), clazz,
SPAN_CLASS_TOKENS, SPAN_CLASS_IDENTIFIERS);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
