matthiasblaesing commented on code in PR #8976:
URL: https://github.com/apache/netbeans/pull/8976#discussion_r2505515472
##########
enterprise/web.jspparser/extsrc/org/apache/jasper/compiler/NodeConverterVisitor.java:
##########
@@ -279,26 +299,34 @@ public void visit(Node.CustomTag n) throws
JasperException {
n.getAttributes(),
convertMark(n.getStart()),
parentNode,
-
n.getTagInfo(),
n.getTagHandlerClass()
);
}
else {
// we do have a tag file
+ Set<String> fragmentAttributes = new HashSet<>();
+ for(TagAttributeInfo tai:
n.getTagFileInfo().getTagInfo().getAttributes()) {
+ if (tai.isFragment()) {
+ fragmentAttributes.add(tai.getName());
+ }
+ }
Review Comment:
Done
##########
enterprise/web.jspparser/src/org/netbeans/modules/web/jsps/parserapi/Node.java:
##########
@@ -1381,17 +1429,25 @@ public boolean hasScriptingVars() {
/**
* Represents a custom tag
*/
+ @SuppressWarnings("UseOfObsoleteCollectionType")
public static class CustomTag extends Node {
+ private static final Set<String> ITERATION_TAGS = new
HashSet<>(asList("jakarta.servlet.jsp.tagext.IterationTag",
"javax.servlet.jsp.tagext.IterationTag"));
+ private static final Set<String> BODY_TAGS = new
HashSet<>(asList("jakarta.servlet.jsp.tagext.BodyTag",
"javax.servlet.jsp.tagext.BodyTag"));
+ private static final Set<String> TRY_CATCH_FINALLY_TAGS = new
HashSet<>(asList("jakarta.servlet.jsp.tagext.TryCatchFinally",
"javax.servlet.jsp.tagext.TryCatchFinally"));
+ private static final Set<String> SIMPLE_TAGS = new
HashSet<>(asList("jakarta.servlet.jsp.tagext.SimpleTag",
"javax.servlet.jsp.tagext.SimpleTag"));
+ private static final Set<String> DYNAMIC_ATTRIBUTES = new
HashSet<>(asList("jakarta.servlet.jsp.tagext.DynamicAttributes",
"javax.servlet.jsp.tagext.DynamicAttributes"));
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
