mbien commented on code in PR #9017:
URL: https://github.com/apache/netbeans/pull/9017#discussion_r2530787475
##########
java/lib.jshell.agent/agentsrc/org/netbeans/lib/jshell/agent/AgentWorker.java:
##########
@@ -462,11 +462,12 @@ private String performExecute(String className, String
methodName, CountDownLatc
userCodeExecutingThreads.put(socketPort,
Thread.currentThread());
}
return super.invoke(className, methodName);
- } catch (ThreadDeath td) {
- LOG.log(Level.FINE, "Received ThreadDeath, killed: {0}", killed);
- if (!killed.get()) {
- throw td;
- }
+ // TODO this code relied on performStop() calling Thread.stop()
+// } catch (ThreadDeath td) {
+// LOG.log(Level.FINE, "Received ThreadDeath, killed: {0}", killed);
+// if (!killed.get()) {
+// throw td;
+// }
Review Comment:
I wasn't able to reach this code path. But I also don't really know all
usecases of the jshell integration, outside of opening it via the tools menu.
But since nobody complained about `UnsupportedOperationException`s so far,
it might be very niche or not reachable anymore at this point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
