mbien commented on PR #9042: URL: https://github.com/apache/netbeans/pull/9042#issuecomment-3632075087
> This PR is handling that using a TypeMirrorHandle. now I know why this felt like a dejavu! I did something similar before and checked all `JavaFix` implementations for missing `TreePathHandle` creation in their constructors https://github.com/apache/netbeans/pull/8860#issuecomment-3336240429, looked through it quickly again and checked TypeMirrors found one more copy/pasted issue: https://github.com/apache/netbeans/blob/3759cc54db547f8e271fe9adaa5d84fa53c53068/enterprise/web.jsf/src/org/netbeans/modules/web/jsf/hints/rules/JakartaFacesBeanIsGonnaBeDeprecated.java#L129-L130 https://github.com/apache/netbeans/blob/3759cc54db547f8e271fe9adaa5d84fa53c53068/enterprise/web.jsf/src/org/netbeans/modules/web/jsf/hints/rules/JavaxFacesBeanIsGonnaBeDeprecated.java#L129-L130 `TypeElement` needs to be wrapped. There doesn't seem to be a handle class for `AnnotationMirror`, but the usage there is a simple string comparison, so the string could be eagerly initialized in the constructor? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
