mbien commented on PR #9098: URL: https://github.com/apache/netbeans/pull/9098#issuecomment-3687306785
no worries. its an iterative process. Updating dependencies can be tricky in NB. Lets see what CI says. I only took a quick look but 2.32.0 makes sense to me since it is what 0.24.0 would resolve to, e.g: ``` mvn eu.maveniverse.maven.plugins:toolbox:gav-tree -Dgav=org.eclipse.lsp4j:org.eclipse.lsp4j.generator:0.24.0 ... [INFO] --- toolbox:0.15.0:gav-tree (default-cli) @ standalone-pom --- [INFO] org.eclipse.lsp4j:org.eclipse.lsp4j.generator:jar:0.24.0 (origin: central) [INFO] ├─org.eclipse.lsp4j:org.eclipse.lsp4j.jsonrpc:jar:0.24.0 [compile] (origin: central) [INFO] │ ╰─com.google.code.gson:gson:jar:2.13.2 [compile] (range '[2.9.1,3.0)') (origin: central) [INFO] │ ╰─com.google.errorprone:error_prone_annotations:jar:2.41.0 [compile] (origin: central) [INFO] ╰─org.eclipse.xtend:org.eclipse.xtend.lib:jar:2.32.0 [compile] (origin: central) [INFO] ├─org.eclipse.xtext:org.eclipse.xtext.xbase.lib:jar:2.32.0 [compile] (origin: central,sonatype-snapshots) [INFO] │ ╰─com.google.guava:guava:jar:32.1.2-jre [compile] (origin: central,sonatype-snapshots) [INFO] │ ├─com.google.guava:failureaccess:jar:1.0.1 [compile] (origin: central,sonatype-snapshots) [INFO] │ ├─com.google.guava:listenablefuture:jar:9999.0-empty-to-avoid-conflict-with-guava [compile] (origin: central,sonatype-snapshots) [INFO] │ ├─com.google.code.findbugs:jsr305:jar:3.0.2 [compile] (origin: central,sonatype-snapshots) [INFO] │ ├─org.checkerframework:checker-qual:jar:3.33.0 [compile] (origin: central,sonatype-snapshots) [INFO] │ ╰─com.google.j2objc:j2objc-annotations:jar:2.8 [compile] (origin: central,sonatype-snapshots) [INFO] ╰─org.eclipse.xtend:org.eclipse.xtend.lib.macro:jar:2.32.0 [compile] (origin: central,sonatype-snapshots) ``` Bytecode level seems to be JDK 11 which is fine too. The gson lib wrapper likely needs updating too (that would be a separate commit since it is an independent module). It would be better to check regarding paperwork: Feel free to squash everything (LSP related) to one commit and force push. The resulting commit must have a valid email address, you can verify it by looking at the generated patch https://github.com/apache/netbeans/pull/9098.patch. Github has a setting somewhere to replace the mail with a noreply address which is probably the reason for it. But you can also update the commit locally which should work too. Once reviewed, we would merge the branch as-is so the commit(s) should also have a descriptive message (e.g without intermediate status updates like "fixed license name" etc which might be left after squashing). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
