mbien commented on code in PR #9112:
URL: https://github.com/apache/netbeans/pull/9112#discussion_r2689909836
##########
.github/workflows/main.yml:
##########
@@ -846,7 +846,7 @@ jobs:
timeout-minutes: 50
strategy:
matrix:
- java: [ '17', '21', '26-ea' ]
+ java: [ '17', '21', '25', '26-ea' ]
Review Comment:
This might make CI a bit less stable temporarily due to the increased matrix
of flaky tests but we would remove JDK 17 for NB 30 anyway so this will soon
fix itself.
good to see that the gradle tests can run on JDK 25 now.
##########
extide/gradle/src/org/netbeans/modules/gradle/api/BuildPropertiesSupport.java:
##########
@@ -255,22 +255,7 @@ public enum PropertyKind {
/**
* Describes a property and its value.
*/
- public static final class Property {
- private final Object id;
- private final String scope;
- private final PropertyKind kind;
- private final String type;
- private final String value;
- private final String name;
-
- public Property(Object id, String scope, String propertyName,
PropertyKind kind, String type, String value) {
- this.id = id;
- this.scope = scope;
- this.kind = kind;
- this.type = type;
- this.value = value;
- this.name = propertyName;
- }
+ public static final record Property(Object id, String scope, String name,
PropertyKind kind, String type, String value) {
Review Comment:
bump
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
