ebarboni commented on PR #127:
URL: 
https://github.com/apache/netbeans-nbpackage/pull/127#issuecomment-3772057192

   LGTM 
   maybe on the site side and to avoid Mxx version,
   
    it possible to use in pom.xml
   
   <version>3.21.0</version> for site-plugin
   skin 
   <skin.version>2.1.0</skin.version>
   
   and use in src/site/site.xml the new root element instead of **project** 
(closing tag at the end should be </site> too)
   <site xmlns="http://maven.apache.org/SITE/2.0.0"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
     xsi:schemaLocation="http://maven.apache.org/SITE/2.0.0 
https://maven.apache.org/xsd/site-2.0.0.xsd";>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to