neilcsmith-net commented on code in PR #9174: URL: https://github.com/apache/netbeans/pull/9174#discussion_r2747309483
########## java/java.hints/src/org/netbeans/modules/java/hints/StaticImport.java: ########## @@ -77,36 +75,36 @@ * * @author Sam Halliday * @author markiewb - * @see <a href="http://www.netbeans.org/issues/show_bug.cgi?id=89258";>RFE 89258</a> - * @see <a href="http://java.sun.com/j2se/1.5.0/docs/guide/language/static-import.html>Static Imports</a> + * @see <a href="https://docs.oracle.com/javase/1.5.0/docs/guide/language/static-import.html>Static Imports</a> */ @Hint(category="rules15", displayName="#DN_StaticImport", description="#DSC_StaticImport", severity=Severity.HINT, enabled=false, suppressWarnings={"", "StaticImport"}, minSourceVersion = "5") public class StaticImport { + + private static final Set<ElementKind> SUPPORTED_TYPES = EnumSet.of(ElementKind.METHOD, ElementKind.ENUM_CONSTANT, ElementKind.FIELD); Review Comment: Yes, I would expect so. The nit was about mutability, not performance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
