mbien commented on PR #9181:
URL: https://github.com/apache/netbeans/pull/9181#issuecomment-3842803237
> I guess I wonder the "polarity" should be reversed, i.e. if there's no
source level, then maybe we should consider the source level to be 9+ nowadays?
Or does that have some known severe impact?
like
```java
if (sourceLevel == null || !sourceLevel.startsWith("1.")) { //NOI18N
// both sourceLevel and ideJDK are 9+
ret = hasModuleInfoCP.get();
}
```
?
changing the bias should be possible I think. But I am not sure why the
source level query exists in the first place, if there is a module-info file,
it can't be <=8 anymore which seems to be the purpose of the check.
I would prefer to keep it as is for NB 29 and consider reverting
https://github.com/apache/netbeans/pull/2037 for NB 30.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
