mbien commented on PR #9151: URL: https://github.com/apache/netbeans/pull/9151#issuecomment-3898803398
> constant aka '17' or '21' in named baseline_jdk would be nice, we already have a constant for the JDK vendor. We probably have too many edge cases still but the way its set up we should be able to put the lower/mid/upper bounds into constants. Its just that sometimes we have releases when we want to test an extra version on a specific job or something like that. > Minor thought might be to rename test.jms.flags which is somewhat misused here by that name. yeah the flag isn't used as intended. But this hopefully only a temporary situation, until the tests are rewritten/removed. As permanent solution it would probably better to add an extra flag instead of renaming. Since some tests use it to reset the jms flags to empty. > And could we move the -J-Dbootstrap.disableJDKCheck=true under a TODO there too? will either add TODOs or check if those added in https://github.com/apache/netbeans/commit/d0793acdbd4b9ddd764c5ce8484cf021e8c38a9d are still needed and maybe remove some. thanks for the reviews! Will try to squash this somehow so that it still makes sense before merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
