matthiasblaesing commented on PR #9176: URL: https://github.com/apache/netbeans/pull/9176#issuecomment-3941766896
I had a quick look at this and it looks sane from the code perspective. Issues I see: - the text in `org.eclipse.tm4e.core-0.17.1-license.txt` has a header with name "License" this header is a reference to a file in `nbbuild/licenses`. The `verify-libs-and-licenses` ant task (you can run that locally yourself. Verifies that the texts match. - the license file and the jar file must match in name only differing in the `-license` injection. So there are two options: You can change the final download name to `org.eclipse.tm4e.core-0.17.1.jar` (notice the change from underscore to dash). Or you can add a `Files:` to the `org.eclipse.tm4e.core-0.17.1-license.txt` file (directly after the Origin header), which get the filename of the jar als value. - the updated textmate grammar can't be parsed as it uses regexps not supported by joni (joni has issues with look-behind patterns). These patterns either have to be manually fixed or the original grammer has to be retained for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
