matthiasblaesing commented on PR #9234: URL: https://github.com/apache/netbeans/pull/9234#issuecomment-3980694100
@DamImpr thanks for taking are and working on this. The CI/CD run showed errors. The execution fails in the `PHPCodeCompletionNb5370Test`. To be precise the `testInterface` one. I ran tests locally and that is the only one failing now. From reading the code the problem is, that `testInterface` is detected as a possible constructor for `TestInterface`. Given the intention of the test, I think the method name is unfortunate and changing it seems sensible. The tests can be run from the IDE by opening the context menu of the project and choose Test there. Be warned: The PHP test suite is extensive. The runs on github take in the range of 45-60 minutes. You can run individual test files be invoking "Test file" on the corresponding java file or the context menu when the file is open. You can also run individual tests be using "Run focused test method from the context menu when you click inside the method body. It would be good if you could add a testcase for the expected behavior. `PHPCodeCompletionGH8644Test` could be an inspiration. The general idea is mostly: 1. Create the test PHP file 2. Add the java side which basicly describes which file to use as basis and which line to check for completion 3. Run the test once. This will generate the "golden" file. You need to check whether that file holds the right information. If so, you commit it together the PHP file, the java unittest file. This triplet will act as regression test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
