ebarboni commented on code in PR #9252:
URL: https://github.com/apache/netbeans/pull/9252#discussion_r2912221346
##########
java/maven/nbproject/project.properties:
##########
@@ -39,16 +39,18 @@ requires.nb.javac=true
test-unit-sys-prop.test.netbeans.dest.dir=${netbeans.dest.dir}
+# TODO update when embedded maven updates
+
# Classpath for agent injected into maven run (sourcecode in mavensrc)
mavensrc.cp=:\
./external/aether-api-1.13.1.jar:\
${libs.json_simple.dir}/modules/ext/json-simple-1.1.1.jar:\
${maven.embedder.dir}/maven/boot/plexus-classworlds-2.9.0.jar:\
${maven.embedder.dir}/maven/lib/javax.annotation-api-1.3.2.jar:\
${maven.embedder.dir}/maven/lib/javax.inject-1.jar:\
- ${maven.embedder.dir}/maven/lib/maven-core-3.9.12.jar:\
- ${maven.embedder.dir}/maven/lib/maven-model-3.9.12.jar:\
- ${maven.embedder.dir}/maven/lib/maven-plugin-api-3.9.12.jar:\
- ${maven.embedder.dir}/maven/lib/maven-resolver-api-1.9.25.jar:\
- ${maven.embedder.dir}/maven/lib/org.eclipse.sisu.plexus-0.9.0.M4.jar:\
+ ${maven.embedder.dir}/maven/lib/maven-core-3.9.14.jar:\
+ ${maven.embedder.dir}/maven/lib/maven-model-3.9.14.jar:\
+ ${maven.embedder.dir}/maven/lib/maven-plugin-api-3.9.14.jar:\
+ ${maven.embedder.dir}/maven/lib/maven-resolver-api-1.9.27.jar:\
+ ${maven.embedder.dir}/maven/lib/org.eclipse.sisu.plexus-1.0.0.jar:\
Review Comment:
ok, and we need aether sonatype for backward compatibility but LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
