sid-srini opened a new pull request, #9263:
URL: https://github.com/apache/netbeans/pull/9263
Fixed `GradleFiles` scan for project files to honour the global scan root
settings, if any.
- Similar to that in projectapi `SimpleFileOwnerQueryImpl`.
- `GradleFiles` needs to necessarily traverse the parent directory hierarchy
to find the root project settings.
- Further, the project detection needs to give precedence to maven projects
also defined for the same directory, which has a similar hierarchy traversal
requirement introduced in #1280.
Fixed `GradleFiles` to find `parentScript` for kotlin script.
- Added a unit test case for it in `GradleFilesTest`.
Fixed `SimpleFileOwnerQueryImplementation` to check for scan root dirs
without allowing sibling dirs with the same name prefix.
- Example: if scan root = "/tmp/app",
- then "/tmp/application" should not be allowed for scan;
- while "/tmp/app" and "/tmp/app/src" should remain allowed.
Fixed `GradleFilesTest` for File comparison on MacOS.
- Needed due to the presence of "/private" prefix in the canonical path of
unix temp folders.
---
**^Add meaningful description above**
<details open>
<summary>Click to collapse/expand PR instructions</summary>
By opening a pull request you confirm that, unless explicitly stated
otherwise, the changes -
- are all your own work, and you have the right to contribute them.
- are contributed solely under the terms and conditions of the Apache
License 2.0 (see section 5 of the license for more information).
Please make sure (eg. `git log`) that all commits have a valid name and
email address for you in the Author field.
If you're a first time contributor, see the Contributing guidelines for more
information.
If you're a committer, please label the PR before pressing "Create pull
request" so that the right test jobs can run.
### PR approval and merge checklist:
1. [ ] Was this PR [correctly
labeled](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=240884239#PRsandYouAreviewerGuide-PRtriggeredCIJobs(conditionalCIpipeline)),
did the right tests run? When did they run?
2. [ ] Is this PR
[squashed](https://cwiki.apache.org/confluence/display/NETBEANS/git%3A+squash+and+merge)?
3. [ ] Are author name / email address correct? Are
[co-authors](https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors#creating-co-authored-commits-on-the-command-line)
correctly listed? Do the commit messages need updates?
3. [ ] Does the PR title and description still fit after the Nth iteration?
Is the description sufficient to appear in the release notes?
If this PR targets the delivery branch: [don't
merge](https://cwiki.apache.org/confluence/display/NETBEANS/Pull+requests+for+delivery).
([full wiki
article](https://cwiki.apache.org/confluence/display/NETBEANS/PRs+and+You+-+A+reviewer+Guide))
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
