Chris2011 commented on PR #4485: URL: https://github.com/apache/netbeans/pull/4485#issuecomment-4058258513
> My gut feeling is, that the HtmlHintsProvider and the expectations of the CslTestBase/GsfHintsManager don't match. It seems suggestions were never really supported. It might be worthy looking into JS/CSS whether there are suggestions being checked. I'm not sure, that modifying CslTestBase is really a good idea. After you said that (in 2024 :D) I checked the PHP implementation of the HtmlHintsProvider and what I found was the missing cancel functionality. And this is what I implemented first. Maybe I have a caching issue locally but after this my test went green and I started to implement more tests and as I said all the tests are green "on my machine" but I know it works on my machine is not the best approach. I will have a look into it. Thx for eyeballing it. I thought some raise condition that came up here but dunno yet. Will check it. I also added some code for the thing that @junichi11 said about embedded php in html. The problem what I see and saw years ago, that still PHP was the best to look into it. CssHintsProvider just handle errors and the rest is empty. Ok with my knowledge nowadays help of some buddies to help me understand the code, the JsHintsProvider can also help. For now maybe I need to make an ant clean build and check the tests again but with not failing tests I dunno how I can verif it and I don't want to spam the PR. I'm working on multiple worktrees maybe this can also be a problem? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
