matthiasblaesing commented on issue #9270: URL: https://github.com/apache/netbeans/issues/9270#issuecomment-4069901138
> If we add documentation, I would probably document in `Lookup` that mutable objects with changing hash code or equals should not be included in them? I think we have multiple other places that could be affected by similar issues. I would not change `Lookup`. That interface only covers the "read" side. And that is not affected by this. The crucial part is the lookup creator needs to define whether it will store identity-shifting objects or not. So I think `AbstractLookup` is the right place as that is the class that a caller needs to instantiate differently and has direct control over. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
