matthiasblaesing commented on code in PR #9284:
URL: https://github.com/apache/netbeans/pull/9284#discussion_r2966879182
##########
nbbuild/test/unit/src/org/netbeans/nbbuild/InsertModuleAllTargetsTest.java:
##########
@@ -102,14 +102,14 @@ public void testInstallAllTargetWithClusters() {
insert.setProject(p);
insert.execute();
-
+
Object obj = p.getTargets().get("all-java.source.queries");
assertNotNull("Target found", obj);
Target t = (Target)obj;
Set<String> s = depsToNames(t.getDependencies());
- assertEquals("Five dependencies: " + s, 5, s.size());
- assertEquals(new HashSet<>(Arrays.asList("init",
"all-openide.dialogs", "all-openide.util", "all-openide.util.lookup",
"all-api.annotations.common")), s);
+ assertEquals("Five dependencies: " + s, 2, s.size());
Review Comment:
```suggestion
assertEquals("Two dependencies: " + s, 2, s.size());
```
##########
nbbuild/test/unit/src/org/netbeans/nbbuild/PrintIconTest.java:
##########
Review Comment:
Is the verbosity level changed intentionally here? I saw in other tests that
you explicitly setup with verbose logging, this is not the case here. This
seems to be the case in other files too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
