OndroMih commented on PR #9324: URL: https://github.com/apache/netbeans/pull/9324#issuecomment-4198756476
@mbien , I implemented the changes you requested, please review again. I added one more optimization - property change listeners run asynchronously - they both do a slow I/O operation for each file and running them asynchronously unblocks the main thread. This doesn't have impact on functionality because the final stage of updating the statuses was already asynchronous and it only updates the icons of files to reflect they status. Here's a sceenshot from profile before the change - the `firePropertyChange` event took 6 seconds: <img width="1745" height="739" alt="image" src="https://github.com/user-attachments/assets/fc1e7d17-4ea5-4be4-82b8-ede1421d9d35"; /> After these changes, when I forced update also on noupdate files, this decreased to 1 second: <img width="1743" height="804" alt="image" src="https://github.com/user-attachments/assets/a258334f-e04f-41f2-96f9-6a43f97bcd4a"; /> When I put back skipping update on noupdate files, the `firePropertyChange` method is rarely called at all. And if it is, then only with a few files that are not marked with noupdate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
