mbien commented on code in PR #9307:
URL: https://github.com/apache/netbeans/pull/9307#discussion_r3049721145
##########
platform/o.n.bootstrap/src/org/openide/modules/DepUtil.java:
##########
Review Comment:
I thought about this and I am leaning towards to keeping it as is atm due to
the following reasons:
- it wouldn't prevent future code movements to solve this in a different
way since nothing is public atm
- to make the new `create()` method public, I would have to add validation
to it and i don't really like to reverse engineer the validation of the other
create method right now. There is also the danger to make it slower again since
it wasn't t here before due to point 3
- it doesn't really have to be public since it is only used internally
without having a purpose for client code
> I have not yet investigated how OSGI reacts to split packages, but I
suspect it will also be problematic.
I am by no means an OSGI expert, but I do remember that even back in the
days OSGI was ok with split packages as long there was no overlap in classes.
E.g if you defined the same class in two modules -> it caused issues. Since
this is friend API, this would be super unlikely to occur by chance.
But I have even less experience with the OSGI impl used within NB or what
spec level it actually is.
@matthiasblaesing @neilcsmith-net please let me know what you both think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
