OndroMih commented on code in PR #9304:
URL: https://github.com/apache/netbeans/pull/9304#discussion_r3067032793
##########
ide/libs.git/src/org/netbeans/libs/git/jgit/commands/StatusCommand.java:
##########
@@ -200,7 +208,6 @@ protected void run () throws GitException {
} else {
continue;
}
- }
Review Comment:
Yes, you are right. I thought that this optimizes the number of calls to
`isEntryIgnored()` but it's still being called later. To be honest, here I used
some AI to help me understand what's the code doing. AI suggested this
optimization and it looked OK to me, but now I see that it only shuffled the
order of execution and didn't optimize anything.
I'll revert these changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
