mbien commented on PR #9323: URL: https://github.com/apache/netbeans/pull/9323#issuecomment-4238155395
> The default properties fallback seems a bit suspect in all this the ant evaluator itself also sets defaults at https://github.com/apache/netbeans/blob/ad4ae127f60e79c8a188ca397e962fc6430ee508/apisupport/apisupport.ant/src/org/netbeans/modules/apisupport/project/Evaluator.java#L400 if we wanted to set a default for NB, where would we put it? build.properties isn't in the context of the evaluator. e.g setting a breakpoint at https://github.com/apache/netbeans/blob/ad4ae127f60e79c8a188ca397e962fc6430ee508/ide/project.ant/src/org/netbeans/spi/project/support/ant/EditableProperties.java#L126 and running `evaluator.getProperty("bootstrap.jdk.release")` returns null. `nbbuild/user.build.properties` does work, but is currently not used and on the gh ignore list. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
