lahodaj commented on code in PR #45:
URL: https://github.com/apache/netbeans-jackpot30/pull/45#discussion_r3223844901
##########
.github/workflows/main.yml:
##########
@@ -46,13 +46,7 @@ jobs:
- name: Set up Ubuntu dependencies
run: |
sudo apt update
- sudo apt install openjdk-17-jdk openjdk-21-jdk
-
- - name: Set up latest JDK 25 from jdk.java.net
- uses:
oracle-actions/setup-java@fff43251af9936a0e6a4d5d0946e14f1680e9b6b # v1.5.0
- with:
- website: jdk.java.net
- release: 25
+ sudo apt install openjdk-17-jdk openjdk-21-jdk openjdk-25-jdk
Review Comment:
Given this project does not currently require a fancy JDK, using one from
the underlying distribution feels like a sensible compromise compared to
potentially controversial distribution selection from `setup-java`.
OTOH, if you want to open a PR to change to `setup-java`, I don't object to
that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
