sid-srini commented on PR #7908: URL: https://github.com/apache/netbeans/pull/7908#issuecomment-4439238139
Hi @matthiasblaesing. Thanks for taking a look at this. Please find my responses below. > This seems to work for NetBeans IDE. But what makes me nervous is: > > * the problems are not reproducible with the NetBeans IDE with an older master build I do not know which older master build did not have these problems reproducible. I have seen this for releases since the last 2-3 years. > * the NetBeans IDE launcher is missing from the launcher enumeration The NetBeans IDE launcher `nb/ide.launcher/unix/netbeans` is essentially invoking the launcher script covered in this PR i.e. `platform/o.n.bootstrap/launcher/unix/nbexec`. The IDE launcher script is a wrapper that performs basic parsing and addition of some extra platform-specific options to the command-line for `nbexec`. The IDE launcher uses eval with `'"$@"'` that will pass forward the user-input arguments literally. The IDE launcher also utilizes env variable values defined in the IDE's `netbeans.conf` file which are populated by the build and mostly do not have such problems. A glitch may occur when the user installs NetBeans in a location like the examples given in the PR description, causing basedir to have such a value. Nonetheless, these are more controlled settings unlike the general user input on the command line. If you prefer similar changes may be added in the wrapper for the default options read from `netbeans.conf`. > * the problems are not reproduible with the NetBeans IDE with this applied > > So what testing was done with the IDE? The problems are not reproducible with the NetBeans IDE with this fix applied. The testing up till now has been done via: - the unit tests for nbexec - manual tests for launching the IDE on command-line with example test values like those given in the PR description, as well as with some non-problematic values. One thing to note is that problematic values with only spaces and not any of the other special characters is handled fine by the IDE launch i.e. nbexec, which used to be a problem with the other launcher that has been removed since NB28. Please let me know what you think. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
