jtulach commented on code in PR #56:
URL: https://github.com/apache/netbeans-html4j/pull/56#discussion_r3246492658
##########
sound/src/main/java/org/netbeans/html/sound/impl/BrowserAudioEnv.java:
##########
@@ -33,9 +33,13 @@ private BrowserAudioEnv() {
}
@Override
- @JavaScriptBody(args = { "src" }, body = ""
- + "if (typeof Audio !== 'object') return null;"
- + "return new Audio(src);")
Review Comment:
Me: I do remember that in 2013 the `typeof Audio` was `object`. When did it
change?
> AI: ... there was a major architectural transition across all major
browsers that changed web API constructors like Audio, Image, and Option from
returning "object" to "function" under the `typeof` operator.
> - Bug 829524 - DOM constructors should be typeof "function".
> - Bug 83849 - Make DOM constructors have typeof 'function'
I haven't found those bugs/commits, but the explanation matches my memories.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
