mbien commented on code in PR #334:
URL:
https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/334#discussion_r3283992678
##########
pom.xml:
##########
@@ -231,7 +232,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-changes-plugin</artifactId>
- <version>2.12.1</version>
+ <version>3.0.0-M3</version>
Review Comment:
should we stick to non-milestone versions?
##########
.mvn/wrapper/maven-wrapper.properties:
##########
@@ -1,19 +1,3 @@
-# Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
accidentally removed license again ;)
##########
pom.xml:
##########
@@ -270,11 +270,33 @@
<configuration>
<targetJdk>${jdkbaseline}</targetJdk>
</configuration>
+ <dependencies>
+ <dependency>
+ <groupId>net.sourceforge.pmd</groupId>
+ <artifactId>pmd-core</artifactId>
+ <version>${pmdVersion}</version>
+ </dependency>
+ <dependency>
+ <groupId>net.sourceforge.pmd</groupId>
+ <artifactId>pmd-java</artifactId>
+ <version>${pmdVersion}</version>
+ </dependency>
+ <dependency>
+ <groupId>net.sourceforge.pmd</groupId>
+ <artifactId>pmd-javascript</artifactId>
+ <version>${pmdVersion}</version>
+ </dependency>
+ <dependency>
+ <groupId>net.sourceforge.pmd</groupId>
+ <artifactId>pmd-jsp</artifactId>
+ <version>${pmdVersion}</version>
+ </dependency>
+ </dependencies>
Review Comment:
why is this required?
##########
pom.xml:
##########
@@ -253,8 +254,7 @@
<dependency>
<groupId>com.puppycrawl.tools</groupId>
<artifactId>checkstyle</artifactId>
- <!-- last jdk 8 compatible version -->
- <version>10.0</version>
+ <version>13.4.2</version>
</dependency>
</dependencies>
Review Comment:
we could try to remove this section, since downgrade prob not needed anymore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
