jtulach commented on code in PR #9433:
URL: https://github.com/apache/netbeans/pull/9433#discussion_r3379522560
##########
java/debugger.jpda.ui/src/org/netbeans/modules/debugger/jpda/ui/SourcePath.java:
##########
@@ -420,10 +420,15 @@ public void showSource (CallStackFrame csf, String
stratumn) {
convertSlash (csf.getSourcePath (stratumn)), true
);
if (url == null) {
- stratumn = csf.getDefaultStratum ();
url = getURL (
- convertSlash (csf.getSourcePath (stratumn)), true
+ convertSlash (csf.getSourcePath
(csf.getDefaultStratum())), true
);
+ for (var anyStratum : csf.getAvailableStrata()) {
Review Comment:
This fallback is only applied if `url` is still `null` after all previous
attempts. E.g. this fallback shall not have any impact on cases where the URL
was found previously.
In Kotlin sources, it seems to work OKeish - the line is selected according
to `Java` strata (that good). However the debugger strata remains `Kotlin`. As
such the current PC line isn't highlighted, just selected. Not ideal, but I am
afraid to switch the strata behind the scene - who knows how that would work in
JSPs, etc.?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
