renatsaf commented on PR #9445: URL: https://github.com/apache/netbeans/pull/9445#issuecomment-4728360585
Done — added `version="27"` to both configs and squashed to a single commit (force-pushed). One note while doing it: a `<platform version="N"/>` entry is actually inert without a matching `JavaSEPlatform` enum constant — `JavaSESet.platforms()` drops unknown version strings via `toValue` (returns `null`), and the installed JDK's spec version is itself resolved through `JavaSEPlatform.toValue` in `JavaUtils.findSupportedPlatforms`. So adding `version="27"` to the XML alone wouldn't have done anything. I added the `v27` enum constant alongside the config entries so 27 is genuinely recognized — and so the enum and config stay in sync, since that asymmetry is exactly what caused this bug. Left the older `GlassFishV7_0_*` configs untouched as you indicated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
