[ 
https://issues.apache.org/jira/browse/OFBIZ-7962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428793#comment-15428793
 ] 

Jacques Le Roux commented on OFBIZ-7962:
----------------------------------------

Actually by patching entityengine.xml you can achieve most of the database 
setup. I never missed anything about that, nor with other environment factors 
(logging, external services URLs, etc.) Essentially you can do everything with 
patching, as you can do everything with assembler. Thanks to diff an patch we 
now live in a solid open source world :) But I agree patching has its limits 
(patching on patches is not possible, and if you need to introduce patch 
versionning things begin to be very complex)

And you are right, you need to be very careful about collisions ("override / 
conflict with other components."), actually any sorts. Note thoug that this is 
not something which will magically dissapear with a Gradle implentation of 
plugins, it will still depend on users awareness. But I totally agree that the 
plugins way is certainly better and safer from this perspective.

Finally, if we are sure to have *similarly strong* "java-based diff libraries 
or other solutions that are independent of surrounding environment." then I 
also agree we have better foundations than those I used to build in 2014 the 
"patch management with Ant targets". They were indeed static and based only on 
patch command (or svn patch). It was pragmatic, was working well but limited 
and was difficult to implement to work on both Win and *nix platforms. With a 
plugins solution we should reach the next level which for me means "dynamic 
patching", with also its own issues, like dependencies between plugins...

When your PoC will be ready we can join forces to eventually have a better 
replacement for those, looking forward !

I wonder though if after all, we will not still need, or at least find 
convenient, to use patches at some moments, it's so simple ;)

> Migrate the patch management Ant targets
> ----------------------------------------
>
>                 Key: OFBIZ-7962
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7962
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>    Affects Versions: Trunk
>            Reporter: Jacques Le Roux
>             Fix For: Upcoming Branch
>
>
> We need to migrate the patch management Ant targets which are documented at 
> https://cwiki.apache.org/confluence/display/OFBIZ/Addressing+Custom+Requirements+In+OFBiz#AddressingCustomRequirementsInOFBiz-PatchManagementUsingGradleTargets



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to