[ 
https://issues.apache.org/jira/browse/OFBIZ-7783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15431624#comment-15431624
 ] 

Jacques Le Roux edited comment on OFBIZ-7783 at 8/22/16 9:03 PM:
-----------------------------------------------------------------

Taher,

Yes I agree about OWASP and the gradle plugin, it's somehow another subject and 
still a WIP. For the rest:
# It should be only used when necessary, so this point is not an issue
# Important point indeed
# moot point
# right!
# Indeed initially I put all libs for OWASP, I then restricted to fill Pierre's 
need, I'd rather extract and copy all the needed external libs 
# Don't put words in my mouth, I did not say it was a way to implement a LAN 
repository, I'm not stupid! It's only a cheap way to extract and copy external 
libs in one place, I agree with your point 5 that some are currently missing to 
be used on test and QA server.

OK, you pointed the negative aspects, now how can we fulfil this goal better? I 
don't mean now, but in future. I agree we should revert because of the point 2 
and 5 and I just did at revision: 1757274 

I'd now would like to know if we will expand this way (possibly in components, 
aka sub-projects) or if we should rather plan to create, or as I said 
elsewhere, document how to create a LAN repository (maybe only suggesting with 
a link to Gradle doc, or even Stackoverflow, but something!). I agree it's time 
to get back to the workbench, ie dev ML.



was (Author: jacques.le.roux):
Taher,

Yes I agree about OWASP and the gradle plugin, it's somehow another subject and 
still a WIP. For the rest:
# It should be only used when necessary, so this point is not an issue
# Important point indeed
# moot point
# right!
# Indeed initially I put all libs for OWASP, I then restricted to fill Pierre's 
need, I'd rather extract and vcopy all the needed external libs 
# Don't put words in my mouth, I did not say it was a way to implement a LAN 
repository, I'm not stupid! It's only a cheap way to extract and copy external 
libs in one place, I agree with your point 5 that some are currently missing to 
be used on test and QA server.

OK, you pointed the negative aspects, now how can we fulfil this goal better? I 
don't mean now, but in future. I agree we should revert because of the point 2 
and 5 and I just did at revision: 1757274 

I'd now would like to know if we will expand this way (possibly in components, 
aka sub-projects) or if we should rather plan to create, or as I said 
elsewhere, document how to create a LAN repository (maybe only suggesting with 
a link to Gradle doc, or even Stackoverflow, but something!). I agree it's time 
to get back to the workbench, ie dev ML.


> External library files are not in the OFBiz folder structure.
> -------------------------------------------------------------
>
>                 Key: OFBIZ-7783
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7783
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>            Reporter: Pierre Smits
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Upcoming Branch
>
>
> With the implementation of the external library download feature of 
> gradle/gradlew, the external libraries (jar files) are not in the folder 
> structure any more. 
> They should reside there, like before.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to