[
https://issues.apache.org/jira/browse/OFBIZ-7950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15443419#comment-15443419
]
Jacques Le Roux commented on OFBIZ-7950:
----------------------------------------
After a review, this looks good to me
> Improve consistency of service createEmployee
> ---------------------------------------------
>
> Key: OFBIZ-7950
> URL: https://issues.apache.org/jira/browse/OFBIZ-7950
> Project: OFBiz
> Issue Type: Improvement
> Components: humanres
> Affects Versions: Trunk
> Reporter: Montalbano Florian
> Priority: Minor
> Labels: consistency, create, employee, service
> Attachments: OFBIZ-7950_proposition.patch
>
>
> In the humanres component, we can create an employee through the form
> https://localhost:8443/humanres/control/NewEmployee .
> This form has required fields that are not the same requirement than the
> service called when submitting the form.
> The service called is createEmployee.
> In the service, everything is declared optional but the
> postalAddContactMechPurpTypeId (which is set in the form as an hidden field).
> This means we could create an Employee without forcing a telephone number or
> a primary address or even a first name.
> But then, within the service, a check is done on the firstName and lastName
> parameters and if missing, an error shows up.
> We could harmonize things a little.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
