Taher Alkhateeb commented on OFBIZ-8156:

I gave you an explanation below of the meaning of the word, so I won't repeat 
myself here.

Now, with respect to the comments above, what I can see is that the API for 
fedex is deprecated, but the bulk of your patch is removing settings, labels 
and standard services.

In my opinion, this is not a clean approach, and a redesign should be favoured 
over blunt removal. the parts that are deprecated can be removed (I still need 
to study the code, but I think most of it is not related) and other parts need 
to be refactored.

> Disentangle Fedex solution from current integrated state
> --------------------------------------------------------
>                 Key: OFBIZ-8156
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-8156
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: commonext, datamodel, order, product, 
> specialpurpose/ecommerce, specialpurpose/oagis, specialpurpose/webpos
>    Affects Versions: Trunk
>            Reporter: Pierre Smits
>            Priority: Minor
>              Labels: 3rdParty, integration, shipment
>         Attachments: OFBIZ-8156-FedexRemoval.patch
> Disentanglement of the 3rd party shipment integration for FedEx gives the 
> OFBiz adopter more flexibility, reduces the default code base and offers the 
> project more opportunities with respect to attracting product specific 
> contributors, better code and faster release cycles.
> Requirements of the disentangled solution:
> * should not need a separate entity to capture configuration elements
> * configuration should be contained in the component.

This message was sent by Atlassian JIRA

Reply via email to