[
https://issues.apache.org/jira/browse/OFBIZ-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15554580#comment-15554580
]
Jacques Le Roux commented on OFBIZ-8154:
----------------------------------------
Ouch, this is very tedious now and I'd appreciate some help, else this will
remain open a long time I guess...
Nevertheless, at r1763695 and r1763701 and I have kept labels wich are actually
used or are useful even if empty.
Now I was removing really unused labels, but I feel it's a pity to do so. I
guess most of them are from pre Apache era and were really never used but since
then the community filled the l10n parts and it does not hurt to not remove
them. I speak for instance about:
{code}
Index: OrderErrorUiLabels.xml
===================================================================
--- OrderErrorUiLabels.xml (revision 1763694)
+++ OrderErrorUiLabels.xml (working copy)
@@ -5119,16 +5119,6 @@
<value xml:lang="zh">在添加到购物车之前请配置产品</value>
<value xml:lang="zh-TW">在添加到購物車之前請配置產品</value>
</property>
- <property key="cart.addToCart.dependencyVariantFeature">
- <value xml:lang="de">Fehler: Eine Abhängigkeit zu einem anderen
Merkmal konnte nicht aufgelöst werden.</value>
- <value xml:lang="en">Error: a dependency to another feature has not
been resolved.</value>
- <value xml:lang="fr">Erreur : une dépendance envers une autre option
n'a pu être résolue.</value>
- <value xml:lang="ja">エラー: 別の機能への依存関係が解消していません</value>
- <value xml:lang="pt-BR">Erro: uma dependência de outra funcionalidade
não foi resolvida</value>
- <value xml:lang="vi">Lỗi xảy ra: một phụ thuộc (dependency) vào tính
năng khác (feature) chưa được xử lý</value>
- <value xml:lang="zh">错误：尚未解决对另一个特性的依赖。</value>
- <value xml:lang="zh-TW">錯誤：尚未解決對另一個特性的依賴。</value>
- </property>
<property key="cart.addToCart.enterAmountBeforeAddingToCart">
<value xml:lang="ar">ادخل المبلغ قبل الإضافة إلى العربة</value>
<value xml:lang="de">Geben sie einen Betrag vor dem Hinzufügen zum
Warenkorb ein</value>
@@ -5183,23 +5173,6 @@
<value xml:lang="zh">没有传递产品信息，没有向购物车添加任何明细。</value>
<value xml:lang="zh-TW">沒有傳遞產品資訊，沒有向購物車添加任何明細。</value>
</property>
- <property key="cart.addToCart.productConfigurationIsNotValid">
- <value xml:lang="ar">الإعدادات غير صالحة</value>
- <value xml:lang="de">Konfiguration ist nicht gültig</value>
- <value xml:lang="en">Configuration Is Not Valid</value>
- <value xml:lang="es">La configuración no es válida</value>
- <value xml:lang="fr">La configuration n'est pas valide</value>
- <value xml:lang="it">Configurazione Non E' Valida</value>
- <value xml:lang="ja">設定が正しくありません</value>
- <value xml:lang="pt-BR">A configuração não é válida</value>
- <value xml:lang="ro">Configurarea Nu este Valida</value>
- <value xml:lang="ru">Неверная конфигурация</value>
- <value xml:lang="th">ไม่มีค่าองค์ประกอบ</value>
- <value xml:lang="vi">Cấu hình tùy chọn không hợp lệ</value>
- <value xml:lang="zh">配置无效</value>
- <value xml:lang="zh-CN">配置无效</value>
- <value xml:lang="zh-TW">配置無效</value>
- </property>
<property key="cart.addToCart.quantityInDecimalNotAllowed">
<value xml:lang="de">Dezimalmenge ist nicht erlaubt.</value>
<value xml:lang="en">Quantity in decimal is not allowed.</value>
@@ -5244,23 +5217,6 @@
<value xml:lang="zh">把 ${totalQuantity} 明细添加到购物车。</value>
<value xml:lang="zh-TW">把 ${totalQuantity} 明細添加到購物車。</value>
</property>
- <property key="cart.agreement_not_specified_to_add_from">
- <value xml:lang="ar">لم تحدد إتفاقية للإضافة من.</value>
- <value xml:lang="de">Kein Vertrag angegeben, aus dem hinzugefügt
werden kann.</value>
- <value xml:lang="en">No agreement specified to add from.</value>
- <value xml:lang="es">No se ha indicado un acuerdo del que se pueda
añadir.</value>
- <value xml:lang="fr">Aucun accord spécifié à partir duquel
ajouter.</value>
- <value xml:lang="it">Nessun contratto specificato da
aggiungere.</value>
- <value xml:lang="ja">追加元の同意が指定されていません。</value>
- <value xml:lang="pt-BR">Nenhum acordo especificado como fonte da
adição.</value>
- <value xml:lang="ro">Nici-un contract specificat de adaugat.</value>
- <value xml:lang="ru">Не указаны договора.</value>
- <value xml:lang="th">ไม่ระบุสัญญาจากการเพิ่ม</value>
- <value xml:lang="vi">Không có thỏa thuận nào để thêm vào.</value>
- <value xml:lang="zh">没有指定要添加进来的合同。</value>
- <value xml:lang="zh-CN">没有指定的协议被加入</value>
- <value xml:lang="zh-TW">沒有指定要添加進來的合同。</value>
- </property>
<property key="cart.amount_not_positive_number">
<value xml:lang="ar">المبلغ يجب أن يكون رقم موجب</value>
<value xml:lang="de">Der Betrag muss eine positive Zahl sein</value>
@@ -5302,40 +5258,6 @@
<value xml:lang="zh-CN">没有指定的分类被加入</value>
<value xml:lang="zh-TW">沒有指定要添加進來的分類。</value>
</property>
- <property key="cart.could_not_add_product_to_cart">
- <value xml:lang="ar">لا يمكن إضافة السلعة ${productId} إلى
العربة</value>
- <value xml:lang="de">Produkt ${productId} konnte dem Warenkorb NICHT
hinzugefügt werden.</value>
- <value xml:lang="en">Could NOT add product ${productId} to
cart.</value>
- <value xml:lang="es">No se puede añadir el producto ${productId} al
carro.</value>
- <value xml:lang="fr">Impossible d'ajouter l'article ${productId} au
panier.</value>
- <value xml:lang="it">NON è Possibile aggiungere prodotto ${productId}
al carrello.</value>
- <value xml:lang="ja">製品 ${productId} を買い物かごに追加できません。</value>
- <value xml:lang="pt-BR">Não foi possível adicionar produto
${productId}</value>
- <value xml:lang="ro">Nu este Posibila adaugare produs ${productId} in
cos.</value>
- <value xml:lang="ru">Не смог добавить продукт ${productId} в
корзину.</value>
- <value xml:lang="th">ไม่สามารถเพิ่มสินค้า ${productId}
ลงตระกร้า</value>
- <value xml:lang="vi">Không thể thêm sản phẩm ${productId} vào giỏ
hàng.</value>
- <value xml:lang="zh">不能把产品 ${productId} 添加到购物车。</value>
- <value xml:lang="zh-CN">不能加入产品 ${productId} 到购物车.</value>
- <value xml:lang="zh-TW">不能把產品 ${productId} 添加到購物車。</value>
- </property>
- <property key="cart.could_not_get_agreement">
- <value xml:lang="ar">لا يمكن المرور للإتفاقية ${agreementId} {read
error}: ${message}.</value>
- <value xml:lang="de">Konnte Vertrag nicht holen mit der Vertrag ID
${agreementId} (Lesefehler): ${message}</value>
- <value xml:lang="en">Could not get agreement through ${agreementId}
{read error}: ${message}.</value>
- <value xml:lang="es">No se pudo obtener el acuerdo con ${agreementId}
{read error}: ${message}.</value>
- <value xml:lang="fr">Impossible d'obtenir un accord par ${agreementId}
{read error} : ${message}.</value>
- <value xml:lang="it">Non è possibile leggere il contratto attraverso
${agreementId} {read error}: ${message}.</value>
- <value xml:lang="ja">同意を取得できません ${agreementId} {読み込みエラー}:
${message}。</value>
- <value xml:lang="pt-BR">Não foi possível obter acordo através do
Acordo ${agreementId} {read error} : ${message}.</value>
- <value xml:lang="ro">Nu este posibila Citirea contractului prin
${agreementId} {read error}: ${message}.</value>
- <value xml:lang="ru">Не смог получить договор в результате
${agreementId} {read error}: ${message}.</value>
- <value xml:lang="th">ไม่สามารถรับข้อสัญญาเนื่องจาก ${agreementId}
{read error}: ${message}.</value>
- <value xml:lang="vi">Không thể lấy điều khoản từ ${agreementId} {đọc
có lỗi}: ${message}.</value>
- <value xml:lang="zh">不能通过 ${agreementId} 获得合同(读错误)：${message}。</value>
- <value xml:lang="zh-CN">不能读取协议 ${agreementId} {read error} :
${message}.</value>
- <value xml:lang="zh-TW">不能通過 ${agreementId}
獲得合同(讀錯誤)：${message}。</value>
- </property>
<property key="cart.could_not_get_products_in_category">
<value xml:lang="ar">لا يمكن إضافة السلع من الفئة ${categorieId} إلى
العربة {read error}</value>
<value xml:lang="de">Produkt(e) aus Kategorie ${categorieId} konnten
nicht zum Warenkorb hinzugefügt werden {read error}.</value>
{code}
I know the easiest, fast, blindly way would be to remove them. But I my mind
OFBiz is there to stay. And I'm sure it's possible to trace where those should
be actually used, so maybe one day someone will do. So I prefer to let them
there. And actually I think I'll stop there but let the issue open in case
anyone wants to take over...
> The entity description labels are considered not used by the Label Manager
> --------------------------------------------------------------------------
>
> Key: OFBIZ-8154
> URL: https://issues.apache.org/jira/browse/OFBIZ-8154
> Project: OFBiz
> Issue Type: Bug
> Components: framework/webtools
> Affects Versions: Trunk
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Minor
>
> As I said in my r1759457 commit comment:
> bq. We have 5237 "Not Used Labels". I wondered if they were all real, I just
> checked some an indeed, they were not used. But there are also a huge bunch
> of *.description.* labels which certainly make sense. I'll remove them from
> the "Only Not Used Labels" result in another Jira I'll create
> Here is the promised Jira
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
