[ 
https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15687651#comment-15687651
 ] 

Jacques Le Roux commented on OFBIZ-9123:
----------------------------------------

Hi Jinghai,

I concur with Michael's opinion, notably the well stated 4 points process.

After a cursory review, I did not find any documentation, either as a README or 
in the wiki. I have also run the pricatdemo and got what seems to be working 
results but I have not ideas of what is expected. I then ran pricat and got 
only this message "No excel import history data".

Pricat does not seem to need much documentation but a minimum is expected ;)

 I did not a thorough review, but globaly this is very simple and seems well 
done, so for me it's only lacking documentation. At this stage I'd not ask to 
revert.

Now I'm more and more thinking about plugins and specialpurpose. When the 
pushPlugin Gradle task will be completed (not only in localhost), I'd prefer to 
have plugins available in an OFBiz common Maven repo (on our demo VM for 
instance).  Then some of the current specialpurpose components and new 
components plugins would be maintained by their contributors, pricat would be a 
good candidate for that.

We could use something like what Pierre proposes with 
https://oem.ofbizci.net/oci-2/ (currently inaccessible with Firefox due to HSTS 
policy, but OK with Chrome) to promote those plugins. It would be good if we 
could have Pierre's work as a common OFBiz feature, again on our demo VM. The 
idea is to have the OFBiz project keeping control over this aspect. If a such 
idea gets support would you contribute your work to the OFBiz project Pierre? 
For now I start the discussion here, but if it gets more interest I'll start it 
again on the dev ML.


> Add a PriCat component under specialpurpose
> -------------------------------------------
>
>                 Key: OFBIZ-9123
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9123
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Trunk
>            Reporter: Shi Jinghai
>            Assignee: Shi Jinghai
>            Priority: Trivial
>             Fix For: Trunk
>
>
> Add a PriCat component to view excel import with html report and download 
> excel output with errors commented.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to