[ 
https://issues.apache.org/jira/browse/OFBIZ-8337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15711242#comment-15711242
 ] 

Nicolas Malin commented on OFBIZ-8337:
--------------------------------------

Hi Taher,
It's also good refactoring for me.

I just found a typo at the line 432 on the last patch but it's a nitpicking :)

> Refactor and simplify the startup sequence in OFBiz
> ---------------------------------------------------
>
>                 Key: OFBIZ-8337
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-8337
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: base, start
>    Affects Versions: Upcoming Release
>            Reporter: Taher Alkhateeb
>            Assignee: Taher Alkhateeb
>            Priority: Minor
>         Attachments: OFBIZ-8337-2.patch, OFBIZ-8337.patch
>
>
> The startup sequence in OFBiz is highly complex and requires improvements on 
> multiple levels including:
> - The entire classpath buildup logic and 
> org.apache.ofbiz.base.start.Classpath needs to be removed. The original idea 
> of classpath isolation between the components created many more problems than 
> it solved, and right now the classpath construction is the responsibility of 
> the build system.
> - The custom classloader needs to be removed as well together with the 
> classpath mentioned above.
> - The StartupLoader interface should remove the start() method and just have 
> two methods, load and unload.
> - The startup sequence should have only one StartupLoader, not an array of 
> startup loaders. This StartupLoader (implemented as ContainerLoader) is the 
> only class responsible for bootstrapping OFBiz
> - The ContainerLoader needs to be completely refactored, not only to remove 
> the start() method but also to cleanup the very messy logic currently 
> residing there.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to